Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 1080832 - [Messages][RTL] Cursor is badly located in recipients and subject when they are empty. r=julien #26097

Closed
wants to merge 1 commit into from
Closed

Conversation

azasypkin
Copy link
Contributor

No description provided.

@try-server-hook
Copy link

azasypkin Aleh Zasypkin (azasypkin) started tests. Results

@@ -717,7 +717,6 @@ Do not remove.
}

#messages-recipients-list > .recipient[contenteditable=true] {
flex-grow: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @eeejay do you remember why you added this in #23013 ? From our point of view it's useless (because we programmatically give the focus if the user click in a blank space in the panel) but maybe you had a reason for a11y?

The consequence of this property is that a recipient being edited takes the whole available space. Without this property it takes only the space its content needs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an accessibility perspective, that empty space that a user clicks needs to have an appropriate role. I had the entry grow and take up all that space, so that a blind user will have an easier time finding it. In other words, the recipient list looks like this in accessibility:
[recipient button], [recipient button], [entry ]

@azasypkin azasypkin closed this Nov 27, 2014
@azasypkin azasypkin deleted the bug-1080832-subject-caret-location branch May 28, 2015 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants